Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing parameters should be done before calling transforms #183

Open
ThibeauWouters opened this issue Feb 13, 2025 · 1 comment
Open

Fixing parameters should be done before calling transforms #183

ThibeauWouters opened this issue Feb 13, 2025 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ThibeauWouters
Copy link
Collaborator

In the current implementation in Jim, there is support to fix some parameters to values specified by the users. In jim.py these are added at the likelihood call here, which appears right after the transforms are called. However, in case the transforms depend on parameters which are fixed, this will throw an error. Therefore, the fixed params should be added at the start of the likelihood call.

@ThibeauWouters ThibeauWouters added the bug Something isn't working label Feb 13, 2025
@tsunhopang
Copy link
Collaborator

In addition to moving the order, one would need to i) ignore the fixed parameter dimension in the Jacobian calculation and ii) assign a random yet fixed value for its log prior.

@kazewong kazewong added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants