diff --git a/src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest.java b/src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest.java index ed1302ba41b3c8..6ac172cb6bbb3f 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest.java @@ -205,7 +205,7 @@ public void testFileVisibilityError() throws Exception { @Test public void testVisibilityErrorNoKeepGoing() throws Exception { - scratch.file("foo/BUILD", "sh_library(name = 'foo', deps = ['//bar'])"); + scratch.file("foo/BUILD", "sh_test(name = 'foo', srcs = ['test.sh'], deps = ['//bar'])"); scratch.file("bar/BUILD", "sh_library(name = 'bar', visibility = ['//visibility:private'])"); try { @@ -222,7 +222,7 @@ public void testVisibilityErrorNoKeepGoing() throws Exception { .getBuildConfigurationCollection() .getTargetConfigurations()); String message = - "in sh_library rule //foo:foo: target '//bar:bar' is not visible from" + "in sh_test rule //foo:foo: target '//bar:bar' is not visible from" + " target '//foo:foo'. Check the visibility declaration of the" + " former target if you think the dependency is legitimate"; assertThat(collector.events.get(topLevel)) diff --git a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java index 7af036de8425db..9c6bb7c7bd491d 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/BuildViewTest.java @@ -1083,7 +1083,7 @@ public void testPostProcessedConfigurableAttributes() throws Exception { reporter.removeHandler(failFastHandler); // Expect errors from action conflicts. scratch.file( "conflict/BUILD", - "config_setting(name = 'a', values = {'test_arg': 'a'})", + "config_setting(name = 'a', values = {'cpu': 'unobtainiumx'})", "cc_library(name='x', srcs=select({':a': ['a.cc'], '//conditions:default': ['foo.cc']}))", "cc_binary(name='_objs/x/foo.o', srcs=['bar.cc'])"); AnalysisResult result =