Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new instancingcompute sample to dub.sdl #59

Closed
floooh opened this issue Mar 8, 2025 · 6 comments
Closed

Add new instancingcompute sample to dub.sdl #59

floooh opened this issue Mar 8, 2025 · 6 comments
Assignees
Labels
question Further information is requested

Comments

@floooh
Copy link
Collaborator

floooh commented Mar 8, 2025

Hi @kassane, I merged the compute shader update and added a new sample instancingcompute.d, but I only added that to the build.zig file.

When you have a minute, could you also add that to the dub.sdl and the list of samples built in the CI?

Thanks :)

@floooh
Copy link
Collaborator Author

floooh commented Mar 8, 2025

PS: any idea what's going wrong here?

https://github.com/kassane/sokol-d/actions/runs/13737192606/job/38422296912

Something about 'previous definition for the same mangled name', only seems to happen in the Dub build...

@floooh
Copy link
Collaborator Author

floooh commented Mar 8, 2025

PS: for now I just removed the dub builds from the CI:

bf6cc28

@kassane
Copy link
Owner

kassane commented Mar 8, 2025

PS: any idea what's going wrong here?

https://github.com/kassane/sokol-d/actions/runs/13737192606/job/38422296912

Something about 'previous definition for the same mangled name', only seems to happen in the Dub build...

Missing add new example in excludedSourceFiles, dub read and join all sources.

# verbose mode 'dub build -v :clear'
ldc2 -d-debug -g -w -d-version=Have_sokol_d_clear -Isrc/ src/examples/clear.d src/examples/instancingcompute.d src/handmade/math.d src/sokol/app.d src/sokol/audio.d src/sokol/debugtext.d src/sokol/fetch.d src/sokol/gfx.d src/sokol/gl.d src/sokol/glue.d src/sokol/imgui.d src/sokol/log.d src/sokol/memtrack.d src/sokol/shape.d src/sokol/time.d -preview=all -i=sokol -i=shaders -i=handmade -c -of/home/kassane/.dub/cache/sokol-d/0.2.0/+clear/build/application-debug-gL22l-IM2wfK2cpJQTjM8g/sokol-d_clear.o -vcolumns

src/examples/clear.d + src/examples/instancingcompute.d

@kassane kassane added the question Further information is requested label Mar 8, 2025
@floooh
Copy link
Collaborator Author

floooh commented Mar 8, 2025

Aaaah ok. Do you have the time to update the dub build (e.g. also add the new sample)? If not I can take care of that tomorrow-ish.

@floooh
Copy link
Collaborator Author

floooh commented Mar 8, 2025

...would it simplify things for Dub to add each sample into its own subdirectory (along with the associated shader)? Some other language binding samples are organized that way.

@kassane
Copy link
Owner

kassane commented Mar 8, 2025

...would it simplify things for Dub to add each sample into its own subdirectory (along with the associated shader)? Some other language binding samples are organized that way.

Yes! It's possible. (like cmake add_subdirectory)
Edit: Sample
info: https://forum.dlang.org/thread/tjvachjznbivzofpiwjw@forum.dlang.org
src: https://github.com/aliak00/dub-subpackages

Tip

dub have command to convert sdl <=> json (dub convert -f dest-format)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants