-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for Wrap
#28
Comments
Hey @karvulf, I came across your package (and this issue) which is exactly what I was looking for. Cheers |
Hi @naamapps, I didn't try to solve this but could take a look the next week. I think this feature will take a bit more work to implement it. |
I have some updates @naamapps return ReorderableBuilder(
children: generatedChildren,
onReorder: _handleReorder,
scrollController: _scrollController,
builder: (children) {
return SingleChildScrollView(
key: _gridViewKey,
controller: _scrollController,
child: Wrap(
children: children,
),
);
},
); It is important that you reorder the widget children by yourself to make sure that the child that has changed his position, has still the correct size. |
That's great to hear @karvulf, |
Ok so I tested and there are indeed a few bugs. Screen_Recording_20220531-091029_2.1.mp4
|
Yes you are right. But it looks that it should be not a big problem to solve that, I will try to make a pull request this weekend, so you can test it again. @naamapps |
Thank you for the support and the great package! |
Hi @naamapps , I made a branch, where I tested this feature, so if you are interested you can take a look into it or test it with your implementation but it's still buggy, so I don't recommend it to use it. To use the feature, you can add the following to your flutter_reorderable_grid_view:
git:
url: https://github.com/karvulf/flutter-reorderable-grid-view.git
ref: 171dfedfc6c0b5f4160ca5bff76b49e11aa36e13 |
Thanks for the update @karvulf, Anyway, I appreciate your work. |
yeah, I was afraid of that, thanks for testing again. I will notify you when I have some updates about the new widget to support the reordering and animating behavior for |
I have some updates for you @naamapps I made a road map for the next major version release |
Hey @karvulf, just checking in. |
Hi @naamapps |
Thanks for the quick reply @karvulf, cheers 👍 |
Just to inform you @naamapps |
Currently, only all types of
GridView
are supported for animation and drag and drop.It would be nice to have also a support for
Wrap
because of similar behaviour.The text was updated successfully, but these errors were encountered: