Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve calculations of scrolling outside or inside #134

Closed
karvulf opened this issue Oct 6, 2024 · 1 comment
Closed

Feature: Improve calculations of scrolling outside or inside #134

karvulf opened this issue Oct 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@karvulf
Copy link
Owner

karvulf commented Oct 6, 2024

Currently there are two ways of getting the current scroll value:

  • inside ReorderableBuilder or outside
  • if it's inside, then ScrollController is required and should be added
  • if it's outside, then ScrollController shouldn't be added because it causes issues

It would be nice if there is a way either of not adding any ScrollController by finding them maybe in the context or the way of getting the scroll value is always the same, e.g. you have always to add ScrollController (outside or inside).
Like this the behavior is more consistent and would probably cause less bugs because I have to focus on only one value.

@karvulf
Copy link
Owner Author

karvulf commented Jan 23, 2025

Because it isn't possible to find the ScrollController, if the child has it, this issue can be closed. The rest was improved and better explained with this PR #154

@karvulf karvulf closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant