-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] make helm buffer can popup as done by shackle. #22
Comments
@zw963 Popper does not provide window management features beyond the minimum necessary to display popups. Helm's height is being limited becuse Helm and Popper are both displayed in side-windows at the bottom of the frame. Note that you'll have the same problem whenever you use a side-window at the bottom along with Helm. To fix this, you have a couple of options.
(add-to-list 'display-buffer-alist
'("\\`\\*helm.*?\\*\\'"
(display-buffer-reuse-window display-buffer-at-bottom)
(window-height . 0.618))) although you may want to tweak it some more.
(defun popper-select-popup-at-top (buffer &optional _alist)
"Display popup-buffer BUFFER at the bottom of the screen."
(let ((win (display-buffer-in-side-window
buffer
`((window-height . ,popper-window-height)
(side . top)
(slot . 1)))))
(select-window win)))
(setq popper-display-function #'popper-select-popup-at-top) |
In fact, not same. because if work with treemacs, with above config, helm only popup on the right window of treemacs window, like this. but, after use shackle, it will popup on full width window. In fact, i use following config which adviced by helm maintainer for a long time, never use shackle, (setq helm-always-two-windows nil) ;; this is default
(setq-default helm-display-buffer-default-height (* (frame-height) 0.618))
(setq helm-default-display-buffer-functions '(display-buffer-in-side-window)) until, i start use emacs-lsp, you know, many little window, helm always limited by this or another window. But, i find this not a big issue anyway after i introduce popper and add those anyway, thank you. |
I try those code, it works! it really a new experience, i will try to play a while, though, that not fix my issue, because helm can be limited by other window which not added into |
The solution is to not use Helm in a side-window. You can use one of the other buffer display functions for You could also show popups in a regular (i.e. non side-) window instead, but you will have continue to have issues with LSP windows etc. |
Thank you for help, let me use for a while, if have any usage issue, i will reopen here. |
Hi, thank you very much for this awesome package.
For my helm issue, is, when one windows get raised, helm will be limited into only in a very little window,
as like this.
helm window be limited into only compile buffer, for the normal case, helm should like behavior like this:
so, for resolve this issue, we can use shackle or popwin, i use former, like this:
But, i find popper! i am curious, is there exists a config for same effect as above shackle config?
Thank you!
The text was updated successfully, but these errors were encountered: