Minor: Better ruby style & remove unnecessary short circuit check #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 6, 2017
lib/retriable/exponential_backoff.rb
Outdated
| @@ -25,18 +26,19 @@ def initialize(opts = {}) | |||
|
|
|||
| def intervals | |||
| intervals = Array.new(tries) do |iteration| | |||
| [base_interval * multiplier**iteration, max_interval].min | |||
| [base_interval * (multiplier ** iteration), max_interval].min | |||
lib/retriable/exponential_backoff.rb
Outdated
| @@ -1,5 +1,6 @@ | |||
| module Retriable | |||
| class ExponentialBackoff | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at class body beginning.
Merge master
kamui
reviewed
Sep 29, 2017
lib/retriable/exponential_backoff.rb
Outdated
| return intervals if rand_factor.zero? | ||
|
|
||
| intervals.map { |i| randomize(i) } | ||
| if rand_factor.zero? |
There was a problem hiding this comment.
Removing the interval check in randomize makes sense, but in this change, I prefer my guard/return/fall-through style rather than if/else. Can you just revert this change, it looks good otherwise.
added 2 commits
September 29, 2017 09:34
apurvis
commented
Sep 29, 2017
| @@ -37,6 +37,7 @@ def retriable(opts = {}) | |||
| on_retry = local_config.on_retry | |||
| sleep_disabled = local_config.sleep_disabled | |||
|
|
|||
| exception_list = on.is_a?(Hash) ? on.keys : on | |||
There was a problem hiding this comment.
(i moved this because i felt like it was hanging out in an awkward place way underneath all the other instantiation variables)
apurvis
added a commit
to apurvis/retriable
that referenced
this pull request
Oct 6, 2017
Minor: Better ruby style & remove unnecessary short circuit check (kamui#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this was redundant;
randomizeis a private method that is never called ifrand_factor.zero?i also made a couple v. small style tweaks; if you don't like them i can change them back but i thought they made it slightly more readable.