-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with Babel JavaScript #4
Comments
@kaminaly hey, do you think you have a chance to help with this issue? |
@ezhlobo Sorry, I also couldn't notice this message :( |
@ezhlobo Hi, I'm not sure but it seems a There are a lot of extensions which are using injection. I think they don't work with |
@kaminaly hm, when babel re-define the pattern, is it possible to create another plugin on top of it to re-define the pattern again? For example now we rely on
If that's the case, do you think we can formulate the issue and share it with its maintainers? Sorry for lots of questions, looks like Babel is so popular so I'm trying to understand if it's possible to support it :). |
@ezhlobo I found an extension which is the same type of https://github.com/Microsoft/vscode-js-atom-grammar According to the readme, This extension replaces the JavaScript grammar in Visual Studio Code with the JavaScript grammar from the Atom editor. I thought the reason for the problem was to replace grammar. that was wrong. |
@kaminaly the real fix is to turn on Atom's grammar (which is used in Babel JavaScript). We can do that by installing official plugin: https://marketplace.visualstudio.com/items?itemName=ms-vscode.js-atom-grammar I believe if we add this information to the README on noticeable place, it will solve the issue for people who install your package and use "Babel JavaScript" plugin. Are you able to add this information to README? So I'll be able to point my colleagues to exact place where they will find the solution for the problem :). |
PS. Found this advice here: michaelgmcd/vscode-language-babel#34 |
@ezhlobo Ok, thanks for your advice. I will add the information to the Readme. the Readme of |
@kaminaly I still don't have strong knowledge in how things work there, so don't know how to comment their README. What I understood (not 100% sure though) is that we either need to patch default grammar (that is what that plugin does) or completely override existed one (that is what babel-language does). Don't know how they both connect with each other, but that made things work for me. |
@ezhlobo do you mean that |
@kaminaly yep, two ways to make it work:
All is cool ;). |
Hey. I'm not a user of VSCode so I'm not aware of how things work there, but it looks like this plugin doesn't work when we use Babel JavaScript (mgmcdermott.vscode-language-babel) plugin.
It will be nice to make it work with commonly used plugins.
The text was updated successfully, but these errors were encountered: