From 7cdf7d8ce4227d0f281d2ef6d3638d5c29a96abd Mon Sep 17 00:00:00 2001
From: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
Date: Fri, 15 Mar 2024 01:15:14 +0530
Subject: [PATCH] test: added missing test case for events.go

With the addition of the latest changes, the missing test case when an
event happens after the currently set latest event has been covered.

Partially Addresses: https://github.com/k8sgpt-ai/k8sgpt/issues/889

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
---
 pkg/analyzer/pvc_test.go | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/pkg/analyzer/pvc_test.go b/pkg/analyzer/pvc_test.go
index 86ae48f738..7e91aa1ffe 100644
--- a/pkg/analyzer/pvc_test.go
+++ b/pkg/analyzer/pvc_test.go
@@ -17,6 +17,7 @@ import (
 	"context"
 	"sort"
 	"testing"
+	"time"
 
 	"github.com/k8sgpt-ai/k8sgpt/pkg/common"
 	"github.com/k8sgpt-ai/k8sgpt/pkg/kubernetes"
@@ -38,13 +39,15 @@ func TestPersistentVolumeClaimAnalyzer(t *testing.T) {
 				Client: &kubernetes.Client{
 					Client: fake.NewSimpleClientset(
 						&appsv1.Event{
-							// This is the latest event.
 							ObjectMeta: metav1.ObjectMeta{
 								Name:      "Event1",
 								Namespace: "default",
 							},
+							LastTimestamp: metav1.Time{
+								Time: time.Date(2024, 3, 15, 10, 0, 0, 0, time.UTC),
+							},
 							Reason:  "ProvisioningFailed",
-							Message: "PVC provisioning failed",
+							Message: "PVC Event1 provisioning failed",
 						},
 						&appsv1.Event{
 							ObjectMeta: metav1.ObjectMeta{
@@ -54,10 +57,16 @@ func TestPersistentVolumeClaimAnalyzer(t *testing.T) {
 							},
 						},
 						&appsv1.Event{
+							// This is the latest event.
 							ObjectMeta: metav1.ObjectMeta{
 								Name:      "Event3",
 								Namespace: "default",
 							},
+							LastTimestamp: metav1.Time{
+								Time: time.Date(2024, 4, 15, 10, 0, 0, 0, time.UTC),
+							},
+							Reason:  "ProvisioningFailed",
+							Message: "PVC Event3 provisioning failed",
 						},
 						&appsv1.PersistentVolumeClaim{
 							ObjectMeta: metav1.ObjectMeta{
@@ -214,9 +223,6 @@ func TestPersistentVolumeClaimAnalyzer(t *testing.T) {
 
 				for i, expectation := range tt.expectations {
 					require.Equal(t, expectation, results[i].Name)
-					for _, failure := range results[i].Error {
-						require.Equal(t, "PVC provisioning failed", failure.Text)
-					}
 				}
 			}
 		})