You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My opinions on the naming aren't strong. The parsing happens on line 62: if (IPAddress.TryParse(host, out IPAddress address)) and with the various other checks on param values.
I think it's correct that this class is more of a factory or builder of IEndPointSource instances than it is a parser (it calls TryParse on another class, it does not implement it) and the naming could be changed to match.
I just stumbled across this comment: https://github.com/justeat/JustEat.StatsD/blob/2c989e99cd9cfe0827d147d5b2cbbf9e35d561b0/src/JustEat.StatsD/EndpointLookups/EndpointParser.cs#L6
Should we rename this type as suggested, or just remove the comment?
At a minimum we should probably rename to
EndPointParser
(capital P) if we don't want to make it a factory.The text was updated successfully, but these errors were encountered: