Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a new database table for the offline cache #74

Closed
justdvnsh opened this issue Oct 12, 2021 · 5 comments
Closed

Make a new database table for the offline cache #74

justdvnsh opened this issue Oct 12, 2021 · 5 comments
Assignees
Labels
feature-request Label to put if requesting a new feature hacktoberfest Issues to solve if participating in hacktoberfest help wanted Extra attention is needed P1 Priority Task - 1

Comments

@justdvnsh
Copy link
Owner

As offline cache has been added to the app, it has disrupted the flow of favorites tab. Since both data is being saved in one single table, so it has messed up the database. We want to save the offline cache into a separate database. The solution to this would be pretty simple. We don't need new entities for cache. We can simply create a new database for cache specifically.

@justdvnsh justdvnsh added help wanted Extra attention is needed hacktoberfest Issues to solve if participating in hacktoberfest feature-request Label to put if requesting a new feature P1 Priority Task - 1 labels Oct 12, 2021
@justdvnsh
Copy link
Owner Author

@krishnachaitanya0107 Want to take this up ?

@krishnachaitanya0107
Copy link
Contributor

Sure @justdvnsh , It would be great if you can guide me a bit on this issue .

@justdvnsh
Copy link
Owner Author

@krishnachaitanya0107 Sure. Well, you don't have to do anything. You just have to create a new file like AnimeDatabase which would also be a room database, but would provide different Dao. that dao would be looking up for animes, deleting animes and everything from the cache anime database you just created. Finally in the database module, provide your database to be injected into the dao. And then provide that dao to the repo, which would be working normally. Does that make sense ?

@krishnachaitanya0107
Copy link
Contributor

All right @justdvnsh , I will start working on the issue . If I feel stuck anywhere I will let you know . Please assign it to me .

@justdvnsh
Copy link
Owner Author

@krishnachaitanya0107 Sure. Happy coding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Label to put if requesting a new feature hacktoberfest Issues to solve if participating in hacktoberfest help wanted Extra attention is needed P1 Priority Task - 1
Projects
None yet
Development

No branches or pull requests

2 participants