Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empack_config file filter does not seem to be working #52

Closed
katotetsuro opened this issue Jan 29, 2024 · 2 comments · Fixed by #53
Closed

empack_config file filter does not seem to be working #52

katotetsuro opened this issue Jan 29, 2024 · 2 comments · Fixed by #53
Labels
bug Something isn't working

Comments

@katotetsuro
Copy link
Contributor

Description

The file filter specified in XeusAddon.empack_config is not used.

https://github.com/jupyterlite/xeus/blob/main/jupyterlite_xeus/add_on.py#L263-L287

Reproduce

jupyter lite build --XeusAddon.empack_config=empack_config.yml

Context

It might be better handled as follows

https://github.com/jupyterlite/xeus-python-kernel/blob/main/jupyterlite_xeus_python/build.py#L321

pack_env(
      env_prefix=self.prefix,
      relocate_prefix="/",
      outdir=out_path,
      use_cache=True,
      **pack_kwargs,
)
@katotetsuro katotetsuro added the bug Something isn't working label Jan 29, 2024
@martinRenou
Copy link
Member

Thank you for opening an issue. I blame myself for not testing the feature properly.

Would you like to open a PR to get credits for your fix?

@katotetsuro
Copy link
Contributor Author

I would like to!
I have created a PR here.
#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants