From 2731adfb5768869c6127f95c29e34e2ecb6e82e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Collonval?= Date: Tue, 29 Nov 2022 17:42:58 +0100 Subject: [PATCH] Use Firefox from playwright (#481) * Use Firefox from playwright * Skip webkit on Ubuntu --- .github/workflows/tests.yml | 8 ++++---- packages/algorithm/tests/karma.conf.js | 2 ++ packages/application/tests/karma.conf.js | 2 ++ packages/collections/tests/karma.conf.js | 2 ++ packages/commands/tests/karma.conf.js | 2 ++ packages/coreutils/tests/karma.conf.js | 2 ++ packages/disposable/tests/karma.conf.js | 2 ++ packages/domutils/tests/karma.conf.js | 2 ++ packages/dragdrop/tests/karma.conf.js | 2 ++ packages/keyboard/tests/karma.conf.js | 2 ++ packages/messaging/tests/karma.conf.js | 2 ++ packages/polling/tests/karma.conf.js | 2 ++ packages/properties/tests/karma.conf.js | 2 ++ packages/signaling/tests/karma.conf.js | 2 ++ packages/virtualdom/tests/karma.conf.js | 2 ++ packages/widgets/tests/karma.conf.js | 2 ++ 16 files changed, 34 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d4636b07c..4f4b7df48 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,11 +12,11 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - browser: [chrome-headless, firefox-headless] + browser: [chrome-headless, firefox-headless, webkit-headless] exclude: - # macos and firefox-headless seems to consistently fail. - - os: macos-latest - browser: firefox-headless + # Playwright webkit binary is not compatible with ubuntu + - os: ubuntu-latest + browser: webkit-headless runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 diff --git a/packages/algorithm/tests/karma.conf.js b/packages/algorithm/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/algorithm/tests/karma.conf.js +++ b/packages/algorithm/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/application/tests/karma.conf.js b/packages/application/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/application/tests/karma.conf.js +++ b/packages/application/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/collections/tests/karma.conf.js b/packages/collections/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/collections/tests/karma.conf.js +++ b/packages/collections/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/commands/tests/karma.conf.js b/packages/commands/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/commands/tests/karma.conf.js +++ b/packages/commands/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/coreutils/tests/karma.conf.js b/packages/coreutils/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/coreutils/tests/karma.conf.js +++ b/packages/coreutils/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/disposable/tests/karma.conf.js b/packages/disposable/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/disposable/tests/karma.conf.js +++ b/packages/disposable/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/domutils/tests/karma.conf.js b/packages/domutils/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/domutils/tests/karma.conf.js +++ b/packages/domutils/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/dragdrop/tests/karma.conf.js b/packages/dragdrop/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/dragdrop/tests/karma.conf.js +++ b/packages/dragdrop/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/keyboard/tests/karma.conf.js b/packages/keyboard/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/keyboard/tests/karma.conf.js +++ b/packages/keyboard/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/messaging/tests/karma.conf.js b/packages/messaging/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/messaging/tests/karma.conf.js +++ b/packages/messaging/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/polling/tests/karma.conf.js b/packages/polling/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/polling/tests/karma.conf.js +++ b/packages/polling/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/properties/tests/karma.conf.js b/packages/properties/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/properties/tests/karma.conf.js +++ b/packages/properties/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/signaling/tests/karma.conf.js b/packages/signaling/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/signaling/tests/karma.conf.js +++ b/packages/signaling/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/virtualdom/tests/karma.conf.js b/packages/virtualdom/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/virtualdom/tests/karma.conf.js +++ b/packages/virtualdom/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN; diff --git a/packages/widgets/tests/karma.conf.js b/packages/widgets/tests/karma.conf.js index 0c30e8967..82380ec18 100644 --- a/packages/widgets/tests/karma.conf.js +++ b/packages/widgets/tests/karma.conf.js @@ -3,6 +3,8 @@ * Distributed under the terms of the Modified BSD License. */ +process.env.FIREFOX_BIN = require('playwright').firefox.executablePath(); +process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN; process.env.WEBKIT_BIN = require('playwright').webkit.executablePath(); process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;