Search "in selected" sometimes reverts to edit mode preventing cell selection

[krassowski]

Description

When searching "in selection" (#14090), switching to command mode and attempting to select multiple cells the mode switches back to edit mode putting cursor back in the cell and preventing selecting more cells.

This appears somewhat similar to seemingly unrelated issue #14271 (could be unrelated or could have to do with recent cursors work)

Reproduce

Expected behavior

When Shift + Up/Shift + Down is pressed the cell selection extends and the command mode remains unchanged.

Context

• JupyterLab version: 4.0.0b

[krassowski]

This looks hard, and originates from CodeMirror focusing the editor back when decorations get updated. Question upstream: https://discuss.codemirror.net/t/how-to-add-decoration-without-focusing-the-editor-on-dispatch/6283

It is still not clear to me why CodeMirror only focuses editor back on some but not all updates to decorations.

[fcollonval]

I tagged this as release blocker as the associated PR changes the API; just to be sure we merge it before the final release.