Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot navigate between cells when focused on output in 3.1.0b1 #10566

Closed
krassowski opened this issue Jul 7, 2021 · 1 comment · Fixed by #10580
Closed

Cannot navigate between cells when focused on output in 3.1.0b1 #10566

krassowski opened this issue Jul 7, 2021 · 1 comment · Fixed by #10580
Assignees
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@krassowski
Copy link
Member

Description

After clicking on the cell output it is no longer possible to move between the cells using arrows keys.

Reproduce

  1. Create a cell with outputs
  2. Try to focus the cell below or above using arrow keys
  3. See that instead the notebook scrolls

causes-scroll

Expected behavior

It should work as in 3.0:

moves-between

Context

  • JupyterLab version: 3.1.0b1
@krassowski krassowski added the bug label Jul 7, 2021
@krassowski krassowski added this to the 3.1 milestone Jul 7, 2021
@krassowski
Copy link
Member Author

Removing this.node.tabIndex = 0; introduced in #10282 solves the problem.

/**
* A `Panel` that's focused by a `contextmenu` event.
*/
export class OutputPanel extends Panel {
/**
* Construct a new `OutputPanel` widget.
*/
constructor(options?: Panel.IOptions) {
super(options);
this.node.tabIndex = 0;
}

@cameron-toy do you have an example situation for which setting the tabIndex was needed in order to focus the panel?

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant