Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ydoc to ^3.0.2 (>=3.0.2,<4) to deliver fixes to users #428

Closed
andrii-i opened this issue Jan 13, 2025 · 2 comments
Closed

Pin ydoc to ^3.0.2 (>=3.0.2,<4) to deliver fixes to users #428

andrii-i opened this issue Jan 13, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@andrii-i
Copy link
Contributor

andrii-i commented Jan 13, 2025

Description

jupyter-ydoc v3.0.2 fixed jupyterlab/jupyterlab#16934.

Currently jupyterlab packages ydoc pin it at ^3.0.0 which is the same as >=3.0.0,<4 so environments with ydoc 3.0.0, 3.0.1 installed or cached would not get this update.

Proposed solution

Pin jupyter_ydoc to ^3.0.2 (>=3.0.2,<4).

I'll be happy to open a PR if community thinks it's a good solution.

@andrii-i andrii-i added the bug Something isn't working label Jan 13, 2025
@krassowski
Copy link
Member

  • v3.0.2 contains exclusively changes in the python package
  • JupyterLab does not depend on the jupyter-ydoc python package
  • even if the changes were in the npm package, changing version ranges in npm @jupyterlab/* packages would not make that much of a difference for users (but it would for extension authors) because it is the version in yarn lock that matters

Given the above I wonder if this issue would be better discussed in jupyter-collaboration repository where there are python packages which do depend on jupyter-ydoc.

@andrii-i andrii-i transferred this issue from jupyterlab/jupyterlab Jan 14, 2025
@andrii-i
Copy link
Contributor Author

andrii-i commented Jan 14, 2025

Fixed by #412 released as a part of v3.1.0beta0 that pins "jupyter_ydoc>=2.1.2,<4.0.0,!=3.0.0,!=3.0.1"

Thank you for suggestions @krassowski, all on point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants