-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New branch: suggestions
#387
Comments
Now that jupyter-collaboration v3.0.0 is out, maybe we should instead create a |
Not sure, maybe it's more convenient if |
Yes, maybe the suggestion system should target v4 then, and we should create a |
In that case, maybe it's fine to keep the |
Yes, the only thing is if @trungleduc needs pre-releases to ease his work in JupyterCAD. I was thinking that we could pre-release v4. |
Right, having a way to make pre-releases would be useful. But do we already know if the work on suggestions will require a major release? Or will it be additive without breaking changes, so it could be made available in a |
with the eventual update related to the Websocket handler, I'm fine working with the PRs. |
Hi all, the |
Hmm didn't you said that you were fine working with PRs? |
yes, but it's is the case of jupytercad. However, I want to open a PR adding JS APIs to your endpoint. Should I open it against your branch in your fork? |
No you're right, I'll create the |
Great! Thanks |
I would like to create a new branch, maybe called
suggestions
, where we would implement new features for the suggestion system. The first PR against this new branch could be:This is to be able to work freely while not blocking any release of jupyter-collaboration, and to iron out the details as we figure them out. Please let me know if there are objections.
The text was updated successfully, but these errors were encountered: