Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch: suggestions #387

Closed
davidbrochart opened this issue Oct 28, 2024 · 12 comments
Closed

New branch: suggestions #387

davidbrochart opened this issue Oct 28, 2024 · 12 comments

Comments

@davidbrochart
Copy link
Collaborator

I would like to create a new branch, maybe called suggestions, where we would implement new features for the suggestion system. The first PR against this new branch could be:

This is to be able to work freely while not blocking any release of jupyter-collaboration, and to iron out the details as we figure them out. Please let me know if there are objections.

@davidbrochart
Copy link
Collaborator Author

davidbrochart commented Oct 29, 2024

Now that jupyter-collaboration v3.0.0 is out, maybe we should instead create a 3.0.0 branch and commit the suggestion system work in main?

@jtpio
Copy link
Member

jtpio commented Oct 30, 2024

Not sure, maybe it's more convenient if main is used for releasing 3.0.x and future 3.1.x for now, since it's not clear how fast the suggestions system will stabilize? (avoid too many backports).

@davidbrochart
Copy link
Collaborator Author

Yes, maybe the suggestion system should target v4 then, and we should create a 4.0.0 branch?

@jtpio
Copy link
Member

jtpio commented Oct 30, 2024

In that case, maybe it's fine to keep the suggestions branch for now, and we create the 4.0.0 branch when needed and when we have more visibility?

@davidbrochart
Copy link
Collaborator Author

Yes, the only thing is if @trungleduc needs pre-releases to ease his work in JupyterCAD. I was thinking that we could pre-release v4.

@jtpio
Copy link
Member

jtpio commented Oct 30, 2024

Right, having a way to make pre-releases would be useful.

But do we already know if the work on suggestions will require a major release? Or will it be additive without breaking changes, so it could be made available in a 3.x minor release?

@trungleduc
Copy link
Member

with the eventual update related to the Websocket handler, I'm fine working with the PRs.

@trungleduc
Copy link
Member

Hi all, the suggestions branch is not created yet?

@davidbrochart
Copy link
Collaborator Author

Hmm didn't you said that you were fine working with PRs?

@trungleduc
Copy link
Member

Hmm didn't you said that you were fine working with PRs?

yes, but it's is the case of jupytercad. However, I want to open a PR adding JS APIs to your endpoint. Should I open it against your branch in your fork?

@davidbrochart
Copy link
Collaborator Author

No you're right, I'll create the suggestions branch and merge #382.

@trungleduc
Copy link
Member

Great! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants