Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure OpenAI magics, support for provider fields in magics #341

Open
dlqqq opened this issue Aug 14, 2023 · 0 comments
Open

Azure OpenAI magics, support for provider fields in magics #341

dlqqq opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dlqqq
Copy link
Member

dlqqq commented Aug 14, 2023

Problem

Right now, there is no general way of providing a field value declared in Provider.fields to a provider via magics. For providers that do require fields, like SageMaker Endpoints, we have to explicitly add a keyword argument for each field we want to support via magics.

This strategy grows increasing untenable as we add more providers with more fields. For example, #322 adds various fields that do not have a corresponding magics implementation.

Proposed Solution

We need to have the magics automatically read from Provider.fields and allow for field values to be passed via magics arguments. There are various ways to implement this; perhaps each Provider declares a magics parser instance as an attribute, and the magics uses each provider's corresponding parser in addition to its own?

@dlqqq dlqqq added the enhancement New feature or request label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant