Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included workflows are not tested on CI #260

Open
krassowski opened this issue Dec 18, 2022 · 2 comments
Open

Included workflows are not tested on CI #260

krassowski opened this issue Dec 18, 2022 · 2 comments
Labels

Comments

@krassowski
Copy link
Member

krassowski commented Dec 18, 2022

Time (#221) and again (jupyter-server/jupyter_releaser#474) and again (#258) the CI workflows generated by cookiecutter turn out to be broken. This is not a good experience for new extension authors, and not a good experience for established developers either.

The question is how to run generated workflows in CI without them being in root .github/workflows.

Two options that I see

  • use https://github.com/nektos/act to execute workflows directly
  • create a branch with the new content, wait for CI on the branch to finish (basically creating a custom service that interfaces between branches/repositories)
    • might be problematic permission-wise
@blink1073
Copy link
Contributor

Another option is to put the business logic in shell scripts, and then execute those directly, as we do in the server cookiecutter

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants