Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: add _ prefix to load_user_options and delete_if_exists #570

Closed
consideRatio opened this issue Feb 22, 2022 · 1 comment · Fixed by #572
Closed

maint: add _ prefix to load_user_options and delete_if_exists #570

consideRatio opened this issue Feb 22, 2022 · 1 comment · Fixed by #572
Labels
breaking maintenance

Comments

@consideRatio
Copy link
Member

I think these functions are private, lets mark them with a leading _ to indicate that as part of going for a KubeSpawner v3 release with the changes in #563.
@manics
Copy link
Member

manics commented Feb 22, 2022

Sounds fine to me, I think systematically adding _ prefixes in all JupyterHub Python repos helps with maintenance. Probably something to bear in mind whenever new functions are added anywhere.

@consideRatio consideRatio mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking maintenance
Projects
None yet
Milestone
No milestone
2 participants
@manics @consideRatio