Find/replace highlighting keeps coming back up after find prompt closed

[James-Huffman]

Description

Highlighting for find/replace in text editor comes back unexpectedly after closing find interface and typing additional text.

Reproduce

1. Open a text document in jupyter notebook.
2. Ctrl-f or use Edit -> Find... to open the find prompt.
3. Type string you want to find
4. Press enter to highlight matching cases in your document
5. Press esc to close the find interface
6. Type any new character - the find highlighting will reappear despite the closed interface.

This seems to only affect the text editor, not find/replace behavior within jupyter notebook cells.

Highlighting is resolved by clearing the find query before closing the find/replace interface.

Expected behavior

Text should remain unhighlighted until the find/replace interface is re-opened.

Context

• Operating System and version: Windows 10 Enterprise
• Browser and version: Chrome 114.0.5735.199

• Jupyter Notebook version: 7.0.0

Troubleshoot Output

[troubleshoot.txt](https://github.com/jupyter/notebook/files/12131167/troubleshoot.txt)

Command Line Output

[command_line.txt](https://github.com/jupyter/notebook/files/12131168/command_line.txt)

Browser Output

No output.

[James-Huffman]

Based on more research, this probably belongs as a bug report for /jupyterlab since it appears that notebook implements this find/replace method from there. Based on an initial test, the same bug behavior is present in jupyterlab. I'm not sure if it's possible to move it without having to completely rewrite this...

[James-Huffman]

I'm not a web developer by any stretch, so take this with a grain of salt. Here goes...

It looks like what get implemented is a searchprovider class from /jupyterlab/packages/documentsearch/src/searchprovider/.ts This is itself an extension of the search provider class from /jupyterlab/packages/codemirror/src/searchprovider.ts.

In order to allow for search in a cell by cell manner in a notebook, this second class has the attribute isActive. This gets checked by the updateCodeMirror method(ln 448). If the query value is set and isActive is true, all matches are highlighted (ln 471). I suspect this bug comes from isActive not being properly handled for File Editor vs how it is handled Notebook on a cell by cell basis.

Again, I don't do web design, so I'm not familiar with these languages. This was my best effort to track down what might be causing this. Hopefully this gives someone a good starting point.

[JasonWeill]

This will likely be fixed as a result of fixing jupyterlab/jupyterlab#14871, filed by the same author. Thank you for your contribution!