Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown headings #title (with no space) #474

Closed
tritemio opened this issue Sep 21, 2015 · 8 comments
Closed

Markdown headings #title (with no space) #474

tritemio opened this issue Sep 21, 2015 · 8 comments

Comments

@tritemio
Copy link
Contributor

Since switching to jupyter notebook 4 the markdown heading that don't have a space between # and the title string do not render as headings anymore.

Is this a deliberate change? Should we start updating all out notebooks using a space between # signs and actual title?

screen shot 2015-09-21 at 11 19 11 am

@Carreau
Copy link
Member

Carreau commented Sep 21, 2015

This is a changed in the underlying library to fix a bug as in the markdown spec the is a space after the hash.

@Carreau Carreau closed this as completed Sep 21, 2015
@Carreau
Copy link
Member

Carreau commented Sep 21, 2015

duplicate of #276 and jupyter/jupyter#16

@tritemio
Copy link
Contributor Author

Thanks for the info. I understand the principle, but it will be painful to update notebooks everywhere :-/.

@tritemio
Copy link
Contributor Author

@Carreau, as you mention in the duplicated issue, a tool (extension adding a menu entry?) to automatically fix notebooks would be quite useful.

@Carreau
Copy link
Member

Carreau commented Sep 21, 2015

On 4.1 you will be able to select search and replace, enable reg-ex and search ^(#+)([^ ]) replace by $1 $2.

@tritemio
Copy link
Contributor Author

Great, awesome! Worth adding it to the migrating to 4.x section of the docs.

@tritemio
Copy link
Contributor Author

@Carreau, I would like to send a PR to add to the docs a section of UI changes in the notebook 4.x.

For now it will contain the info in this issue and the new shortcuts to select and merge multiple cells (I initially though the merge shortcut was broken).

Which repo should I target, notebook or the main jupyter docs at:

http://jupyter.readthedocs.org/en/latest/migrating.html#migrating-from-ipython

I would prefer adding only a link in the previous page and a new section in the notebook docs.

@sebastien-bratieres
Copy link

I guess the regex to match should not be ^(#+)([^ ]) but ^(#+)([^ #]) (otherwise, in case of headings of level 2 and more, the last # will match the second group).

@minrk minrk added this to the no action milestone Dec 14, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants