Cmd/Ctrl clicking folders no longer opens in new tabs in 5.3

[parente]

Instead, the file browser navigates to the folder in the current browser pane.

Probably related to the new history navigation feature. JS might be eating the hotkey modifier preventing the default browser behavior.

[takluyver]

Oh, I hadn't checked that because I use middle click to open in a new tab. I think you're right about the cause.

[parente]

No worries. One of our users caught it after we rolled it out internally.

[takluyver]

Want to do a PR? The handler is here:

notebook/notebook/static/tree/js/notebooklist.js

Lines 814 to 824 in 3de5e50

	link.click(function (e) {
	window.history.pushState({
	path: model.path
	}, model.path, utils.url_path_join(
	that.base_url,
	'tree',
	utils.encode_uri_components(model.path)
	));
	that.update_location(model.path);
	return false;
	});

And we should probably do the same with the breadcrumb handlers:

notebook/notebook/static/tree/js/notebooklist.js

Lines 367 to 391 in 3de5e50

	var root = $('<li/>').append('<a href="/tree"><i class="fa fa-folder"></i></a>').click(function(e) {
	var path = '';
	window.history.pushState({
	path: path
	}, 'Home', utils.url_path_join(that.base_url, 'tree'));
	that.update_location(path);
	return false;
	});
	breadcrumb.append(root);
	var path_parts = [];
	this.notebook_path.split('/').forEach(function(path_part) {
	path_parts.push(path_part);
	var path = path_parts.join('/');
	var url = utils.url_path_join(
	that.base_url,
	'/tree',
	utils.encode_uri_components(path)
	);
	var crumb = $('<li/>').append('<a href="' + url + '">' + path_part + '</a>').click(function(e) {
	window.history.pushState({
	path: path
	}, path, url);
	that.update_location(path);
	return false;
	});

[parente]

I was planning to dig into it tomorrow evening. If someone else gets to it before me, no worries.