Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6? #148

Closed
davidbrochart opened this issue May 7, 2021 · 3 comments
Closed

Drop Python 3.6? #148

davidbrochart opened this issue May 7, 2021 · 3 comments

Comments

@davidbrochart
Copy link
Member

IPython dropped Python 3.6 from version 7.21.0, ipykernel 6 will require IPython 7.23.1, and we use IPython in our tests.
Should we also drop Python 3.6?

@kevin-bates
Copy link
Member

Thanks for bringing this up David. Would this only be in regards to our 7.0 release?

I'm surprised pip wouldn't just do the right thing - assuming ipykernel is properly decorated relative to required releases and we're not relying on functionality only in ipykernel 6.

@davidbrochart
Copy link
Member Author

Would this only be in regards to our 7.0 release?

Do you mean jupyter_client 7.0? No, regardless of jupyter_client.

I'm surprised pip wouldn't just do the right thing - assuming ipykernel is properly decorated relative to required releases and we're not relying on functionality only in ipykernel 6.

Yes, you're right, pip couldn't do the right thing in #146 because I explicitly installed ipykernel master. With a constraint of 5<=ipykernel<7 or so, everything should be fine. Thanks Kevin!

@kevin-bates
Copy link
Member

Do you mean jupyter_client 7.0? No, regardless of jupyter_client.

Oh my - I knew this would happen one day and I am so sorry! You are absolutely right, my comment was related to the jupyter_client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants