Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare next ipykernel #143

Closed
davidbrochart opened this issue Apr 14, 2021 · 4 comments · Fixed by #147
Closed

Prepare next ipykernel #143

davidbrochart opened this issue Apr 14, 2021 · 4 comments · Fixed by #147

Comments

@davidbrochart
Copy link
Member

ipykernel 6.0.0 will break our tests, see ipython/ipykernel#635 (comment).
We will need to update the cell outputs of our test notebooks.
@MSeal
Copy link
Contributor

MSeal commented Apr 14, 2021

Thanks for digging into that -- it looks like we need to soften output error message matching in our tests? I think the new file path names will be randomized yes?

@davidbrochart
Copy link
Member Author

Yes, it will be a random file path. I agree that we need to have these tests more tolerant.

@davidbrochart
Copy link
Member Author

davidbrochart commented Apr 27, 2021 •
edited
Loading

Now that ipython/ipykernel#652 is merged, tests should pass with ipykernel master if we set the following:

export IPYKERNEL_CELL_NAME="<IPY-INPUT>"

@davidbrochart davidbrochart mentioned this issue Apr 27, 2021
Merged
@davidbrochart
Copy link
Member Author

Indeed, tests pass in #146. Let's get #147 in to prepare for ipykernel 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set IPYKERNEL_CELL_NAME = <IPY-INPUT>
2 participants
@MSeal @davidbrochart