Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI test against another kernel #728

Closed
blink1073 opened this issue Dec 16, 2021 · 2 comments · Fixed by #731
Closed

Add a CI test against another kernel #728

blink1073 opened this issue Dec 16, 2021 · 2 comments · Fixed by #731

Comments

@blink1073
Copy link
Contributor

Problem

We are currently only testing against ipykernel. If we were testing against at least one other kernel we can be more confident that our changes are not adversely affecting other kernels.

Proposed Solution

Add a CI job that installs IRKernel in a conda environment and runs a test that launches IRKernel and executes code. What we could do is run test_irkernel.py using a local checkout of jupyter_kernel_test, which we are currently doing only for test_ipykernel.py.

Additional context

Use jupyter_kernel_test as an example for the CI setup.

@davidbrochart
Copy link
Member

+1
What about also testing IJulia?

@blink1073
Copy link
Contributor Author

Good point, I was able to set it up pretty quickly locally:

  • Create conda env with julia and jupyterlab
  • Run julia -e 'using Pkg; Pkg.add("IJulia")'
  • Run jupyterlab and launch Julia kernel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants