-
Notifications
You must be signed in to change notification settings - Fork 210
setup.py should use ConfigManager / jupyter_notebook_config.json #153
Comments
/cc @lbustelo because I bet declarative widgets have the same issue. |
Fixed by #156 |
Reopening. In the associated PR, I switched over to using the ConfigManager class to add the server-side extension to So which is the preferred way? If we stick with the I know this is related to the discussion going on in jupyter/notebook#331 and jupyter/enhancement-proposals#7 about better support for 4.x extensions. Ahead of general consensus on those issues, is there, or can we define, a preferred best practice for which of these two config approaches, .py or .json, should be used for server-side extensions in particular? @ellisonbg, can you comment or add folks who can? |
/cc @lbustelo |
Reverted to old technique to retain compat across the incubator projects. Will open PRs across all the associated repos switching them en masse to JSON config at a later date. When notebook 4.2 is out with an even better nbextension install story, we'll move to that as part of the fix for issue #155. |
With 0.3.0 out, there's no longer any server-side extension to configure in this repo. All we need to handle is JS install which will be addressed in #155. |
See discussion in #152. Either change setup so that it creates an initial config file if one does not exist, or have it fail with a human readable error. The latter might be preferred in case the user does not know he/she is installing as the wrong user.
The text was updated successfully, but these errors were encountered: