Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow the DAP for the inspectVariables response #194

Closed
jtpio opened this issue Jan 30, 2020 · 1 comment · Fixed by #195
Closed

Follow the DAP for the inspectVariables response #194

jtpio opened this issue Jan 30, 2020 · 1 comment · Fixed by #195

Comments

@jtpio
Copy link
Member

jtpio commented Jan 30, 2020 •
edited
Loading

At the moment the inspectVariables request gets all the variables from the running kernel with globals(), which are then returned as-is in the response.

Ideally, the response could follow the same structure as for the variables response from the DAP, and return a list of Variable (probably with the optional fields left out, at least for now).

Related to https://github.com/jupyterlab/debugger/issues/118.
@jtpio
Copy link
Member Author

jtpio commented Jan 30, 2020

This was also mentioned in: jupyter/enhancement-proposals#47 (comment)

@jtpio jtpio mentioned this issue Jan 30, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Follow the DAP for inspectVariables response jtpio/xeus-python
1 participant
@jtpio