Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_other_extensions=False in ExtensionApp #211

Closed
davidbrochart opened this issue Apr 25, 2020 · 1 comment · Fixed by #214
Closed

load_other_extensions=False in ExtensionApp #211

davidbrochart opened this issue Apr 25, 2020 · 1 comment · Fixed by #214
Milestone
1.0 Release

Comments

@davidbrochart
Copy link
Contributor

I don't understand how an ExtensionApp is supposed to work when it has load_other_extensions=False. Isn't it going to prevent loading itself also when launched directly?
In the simple_ext1 example, if you set this line to False, then python -m simple_ext1 will show a 404 error in the browser.
@Zsailer
Copy link
Member

Zsailer commented Apr 27, 2020

Good catch. This is a bug.

Looks like this was dropped in #180 by accident. I'll work on a fix + some tests today.

@Zsailer Zsailer added this to the 1.0 Release milestone Apr 27, 2020
@Zsailer Zsailer mentioned this issue Apr 28, 2020
Merged
@davidbrochart davidbrochart mentioned this issue May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 Release
Development

Successfully merging a pull request may close this issue.

Add option to load extensions listed on jupyter_config_path Zsailer/jupyter_server
2 participants
@Zsailer @davidbrochart