Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantically correct element for closed captions element #428

Open
Neo-Oli opened this issue Mar 27, 2024 · 0 comments
Open

Use semantically correct element for closed captions element #428

Neo-Oli opened this issue Mar 27, 2024 · 0 comments

Comments

@Neo-Oli
Copy link
Contributor

Neo-Oli commented Mar 27, 2024

Hi

The closed caption element should probably be a <span>. I want our cc element to be a <p> since that makes semantically the most sense for us (but I could see people deciding on something else). <div> will get rendered inside our <p> now, but <div> inside <p> (or most other text elements) is semantically invalid.

const divElement = document.createElement("div");

I implemented chart(js)2music now and noticed a few bugs. So that's why I am creating several issues, but overall I'm quite happy with the plugin. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant