Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace/didChangeConfiguration's setting can be Nothing #324

Closed
FelipeLema opened this issue Jan 8, 2019 · 1 comment
Closed

[workspace/didChangeConfiguration's setting can be Nothing #324

FelipeLema opened this issue Jan 8, 2019 · 1 comment

Comments

@FelipeLema
Copy link

FelipeLema commented Jan 8, 2019 •
edited
Loading

workspace/didChangeConfiguration's setting can be Nothing.

This can be fixed by testing against r.params["settings"] != nothing in process(r::JSONRPC.Request{Val{Symbol("workspace/didChangeConfiguration")},Dict{String,Any}}, server) before doing haskey(…)

Related to joaotavora/eglot#59 (I also found it because eglot reports "nothing" there).
@ZacLN
Copy link
Contributor

ZacLN commented Jan 8, 2019

Cheers, fixed on master

@ZacLN ZacLN closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FelipeLema @ZacLN