Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back-compat for old-style sentry indexing #111

Open
tvansteenburgh opened this issue Dec 4, 2015 · 1 comment
Open

Add back-compat for old-style sentry indexing #111

tvansteenburgh opened this issue Dec 4, 2015 · 1 comment

Comments

@tvansteenburgh
Copy link
Contributor

When a test does sentry['mycharm/0'], do sentry['mycharm'][0] behind-the-scenes instead of returning a KeyError. I.e., use the unit num as an index into the sentry array. This will make old tests work again without having to update them all. Arguably this is what we should have done in the first place.
@johnsca
Copy link
Contributor

johnsca commented Dec 4, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnsca @tvansteenburgh