Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serde_yaml with serde_yml #1168

Closed
DenuxPlays opened this issue Oct 27, 2024 · 5 comments · Fixed by #1280
Closed

Replace serde_yaml with serde_yml #1168

DenuxPlays opened this issue Oct 27, 2024 · 5 comments · Fixed by #1280

Comments

@DenuxPlays
Copy link
Contributor

The serde_yaml crate is archived and will not be updated.
There is a fork however named serde_yml.

It should be replace it with the actively maintained fork.

@juhaku
Copy link
Owner

juhaku commented Oct 27, 2024

Yeah, it probably is a good idea to replace the serde_yaml with serde_yml as it seems to take the initiative to continue the legacy of serde_yaml in yaml support for rust.

@domenicquirl
Copy link

While I appreciate the intention here, there are some concerns around serde_yml FYI: rustsec/advisory-db#2212. I know the deprecation of the original serde_yaml was a hard-hitter, but at least there was pretty high confidence for the original crate to be well-maintained and, most importantly, sound.

I'd strongly consider looking for a different alternative (there are other forks of the original, like https://github.com/acatton/serde-yaml-ng for example).

@DenuxPlays
Copy link
Contributor Author

Yeah I agree.

I am sorry I wasn't aware of this.

Although I don't think that serde-yaml-ng is a good alternative as it seems to be unmaintained or atleast the last real commit was 5 months ago.

But it should be better to use this then serde_yml

Again I am sorry for my poor research :(

@DenuxPlays
Copy link
Contributor Author

I've found this replacement: https://crates.io/crates/serde_norway

Looks promising

@domenicquirl
Copy link

Sounds good to me!

And no need to apologize, it's still the most downloaded fork, I get that it looks very appealing (probably even more so then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants