You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ParameterGroupNumber class has an inner class PGN which defines a bunch of useful PGN constants.
But some of them are commented out, for exampleSOFTWARE_IDENT (which has value 0xFEDA).
I am wondering whether there is a reason for them being commented out, versus perhaps we can uncomment them and make them available for people to use?
The current situation makes things interesting when trying to develop code to work with the library. As a workaround, I have defined my own subclass of ParameterGroupNumber.PGN class which fills in some of the blanks, but I would prefer to submit a PR so that it can be fixed in the library itself, unless someone knows of a reason for leaving things as they are...?
The text was updated successfully, but these errors were encountered:
The
ParameterGroupNumber
class has an inner classPGN
which defines a bunch of useful PGN constants.But some of them are commented out, for example
SOFTWARE_IDENT
(which has value0xFEDA
).I am wondering whether there is a reason for them being commented out, versus perhaps we can uncomment them and make them available for people to use?
The current situation makes things interesting when trying to develop code to work with the library. As a workaround, I have defined my own subclass of
ParameterGroupNumber.PGN
class which fills in some of the blanks, but I would prefer to submit a PR so that it can be fixed in the library itself, unless someone knows of a reason for leaving things as they are...?The text was updated successfully, but these errors were encountered: