Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we uncomment some of the named-constant definitions in ParameterGroupNumber.PGN class? #66

Open
grant-allan-ctct opened this issue Dec 11, 2023 · 0 comments

Comments

@grant-allan-ctct
Copy link
Collaborator

The ParameterGroupNumber class has an inner class PGN which defines a bunch of useful PGN constants.

But some of them are commented out, for example SOFTWARE_IDENT (which has value 0xFEDA).

I am wondering whether there is a reason for them being commented out, versus perhaps we can uncomment them and make them available for people to use?

The current situation makes things interesting when trying to develop code to work with the library. As a workaround, I have defined my own subclass of ParameterGroupNumber.PGN class which fills in some of the blanks, but I would prefer to submit a PR so that it can be fixed in the library itself, unless someone knows of a reason for leaving things as they are...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant