Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECU connected using pcan not notifying subscribers #19

Open
jedpop opened this issue Jan 23, 2022 · 1 comment
Open

ECU connected using pcan not notifying subscribers #19

jedpop opened this issue Jan 23, 2022 · 1 comment

Comments

@jedpop
Copy link

jedpop commented Jan 23, 2022

I found that when the ECU is connected using socketcan, subscribers to the ECU do get notified when CAN bus messages are received but when pcan is used for the connection the subscribers do not get notified. Tried a few things and looked at the j1939 library code but cannot figure out the cause.

I was using an earlier version and found this but upgraded to v2.0.5 and the issue remains.

Update: I forgot to check the Closed Issues (sorry) and noticed #11 (comment) may address this issue. I did try to add the address in the subscribe but used an integer value. The docs seem to indicate that if the address parameter isn't included then it would notify all subscribers. I'll try this with the hex address and update. I would prefer the approach of notification of all messages if the address isn't included (IMO).

@grant-allan-ctct
Copy link
Collaborator

Depending upon which PGNs were not arriving, @jedpop, this might be the same as #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants