Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Postgres TLS #741

Closed
Zk2u opened this issue Aug 15, 2022 · 1 comment · Fixed by #745
Closed

Support Postgres TLS #741

Zk2u opened this issue Aug 15, 2022 · 1 comment · Fixed by #745
Labels
enhancement New feature or request

Comments

@Zk2u
Copy link
Contributor

Zk2u commented Aug 15, 2022

Feature request

Support for Postgres DBs to use TLS during connection. Maybe add a config option that switches it on/off. Changes would be made to the following lines in app.go.

dbString = fmt.Sprintf(
	"host=%s port=%d dbname=%s user=%s password=%s sslmode=disable",
	cfg.DBhost,
	cfg.DBport,
	cfg.DBname,
	cfg.DBuser,
	cfg.DBpass,
)

Our databases run on separate machines on the same network, TLS connections are essential for security.

This is simple to change and I have it working with a quick patch, but thought I should open a PR to push a more polished version upstream later.

@Zk2u Zk2u added the enhancement New feature or request label Aug 15, 2022
@juanfont
Copy link
Owner

@617a7a this looks like a simple change. Can you raise a PR?

@juanfont juanfont added this to the v0.17.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants