Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

[Bug] Potential temporary memory leak when a webpage inserts and removes lots of frames #799

Open
jspenguin2017 opened this issue Jan 9, 2018 · 2 comments
Open

[Bug] Potential temporary memory leak when a webpage inserts and removes lots of frames #799

jspenguin2017 opened this issue Jan 9, 2018 · 2 comments
Labels
Bug

Comments

@jspenguin2017
Copy link
Owner

jspenguin2017 commented Jan 9, 2018 •
edited
Loading

  1. When the main frame is navigated, its frames are not cleared from tab store.
  2. When a frame is removed, it is not reflected in the tab store.

The first problem is easy to fix, but it's not that important, maybe 1 kB here and there, no rush for that.
The second problem is more difficult to fix, it affects uBlock Origin (and Nano) as well.
jspenguin2017 added a commit that referenced this issue Jan 11, 2018
@jspenguin2017
https://github.com/jspenguin2017/uBlockProtector/issues/799
70c5162
@jspenguin2017
Copy link
Owner Author

1 is fixed. I'm not sure how to deal with 2 though...

@jspenguin2017 jspenguin2017 changed the title Potential temporary memory leak when a webpage inserts and removes lots of frames [Bug] Potential temporary memory leak when a webpage inserts and removes lots of frames Jan 17, 2019
@jspenguin2017
Copy link
Owner Author

gorhill/uBlock@feabfe3

jspenguin2017 referenced this issue in gorhill/uBlock Jul 18, 2020
@gorhill
Do let grow subframe dictionary grow unbound
feabfe3 
Related discussion:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1652925

It's not clear the code here will fix the reported
issue, but I did identify that the subframe
dictionary of a very long-lived web page can
theoretically grow unbound.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jspenguin2017