Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow fragments in id URIs #22

Closed
JanTvrdik opened this issue Apr 21, 2016 · 2 comments
Closed

Disallow fragments in id URIs #22

JanTvrdik opened this issue Apr 21, 2016 · 2 comments

Comments

@JanTvrdik
Copy link

JanTvrdik commented Apr 21, 2016

It seems that the some of problems with $refs and id could be alleviated by disallowing fragments in id URIs.

Currently such fragments

  • collide with JSON pointers and
  • make strange distinctions between outer-most schema (which currently can not have fragment in id) and inner schemas (which can have fragments in id)
@awwright
Copy link
Member

@JanTvrdik Take a look at the changes introduced in #50 and see if any of the problems you describe could still exist, please? I'd like to see examples of problems if you think they're still present.

Thanks!

@awwright
Copy link
Member

As best as I can tell, I think a pretty good solution is worked out in the repository now.

If after the draft is published, it doesn't seem to address the issue, feel free to raise any concerns you have. Thanks!

@awwright awwright added this to the draft-5 milestone Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants