Test failed on node version 10 and 11

[arstgit]

Looks like error event trigger has changed on new version of node .

[dougwilson]

Thanks for the report, I will take a look!

[dougwilson]

This is due to change of behavior in Node.js 10 that seems unsolvable without changes to Node.js core to restore insight into parser errors.

I filed issues nodejs/node#24586 and nodejs/node#24585

There isn't anything I can really do to fix, unfortunately.

[dougwilson]

Per Node.js core: this module will never work on Node.js 10+

[PixnBits]

That was an adventure ☹️
per nodejs/node#24586 (comment) and expressjs/express#3813 (comment) has this been resolved or is it still a bug?
BTW, thank you for fighting for the users

[dougwilson]

Hi @PixnBits sorry about that 😅 So on Node.js 10 (and 11) this module is fixed … but not fixed. So what I mean by that is the test suite for this module still fails on Node.js 9, but on 10 and 11 the test suite does pass, though there are a bunch of edge cases in this module where it doesn't properly detect the finished state. I have been working on a complete re-write of this module to address theses issue and get it working across all the Node.js versions needed for Express.js 4.x in order to get it included in the next Express.js 4.x release.

[PixnBits]

Not a problem, thanks so much!