Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.19 does weird validation #41

Closed
kristerkari opened this issue Nov 10, 2014 · 3 comments · Fixed by #42
Closed

v0.0.19 does weird validation #41

kristerkari opened this issue Nov 10, 2014 · 3 comments · Fixed by #42
Assignees
Labels

Comments

@kristerkari
Copy link

Using JSCS v1.7.3

With jsDoc options:

    "jsDoc": {
        "checkParamNames": true,
        "checkRedundantParams": true,
        "requireParamTypes": true,
        "checkReturnTypes": true,
        "requireReturnTypes": true,
        "checkTypes": true,
        "checkRedundantReturns": true,
        "checkRedundantAccess": true,
        "leadingUnderscoreAccess": "private"
    }

This code in v0.0.19:

/**
 * Test
 *
 * @param {String} mystr
 * @return {String}
 */
exports.testStr = function(mystr) {
    'use strict';
    return mystr;
};

Validates as:

↳ jscs server/lib/test.js
redundant param statement at server/lib/test.js :
     1 |/**
--------^
     2 | * Test
     3 | *

missing param name at server/lib/test.js :
     3 | *
     4 | * @param {String} mystr
     5 | * @return {String}
-----------^
     6 | */
     7 |exports.testStr = function(mystr) {


2 code style errors found.

v0.0.16 will pass the checks

@qfox
Copy link
Member

qfox commented Nov 10, 2014

@kristerkari Shame on me. Don't look at code diff plx ;-D

@qfox qfox closed this as completed in #42 Nov 10, 2014
@qfox qfox added the bug label Nov 10, 2014
@qfox qfox self-assigned this Nov 10, 2014
@qfox
Copy link
Member

qfox commented Nov 10, 2014

@kristerkari Thank you very much for this ;-)

Fixed and published v0.0.20

@kristerkari
Copy link
Author

Works now, thanks for quick fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants