From 792be3db0cedff14396385c762b8cd327da3bc47 Mon Sep 17 00:00:00 2001 From: Christopher Hiller Date: Sun, 9 Nov 2014 23:06:36 -0800 Subject: [PATCH] checkRedundantParams, checkParamNames: add jsdoc check, etc - fix several exceptions when validating files missing jsdoc tags Closes #37 Closes #38 --- lib/rules/validate-jsdoc/check-param-names.js | 4 ++++ lib/rules/validate-jsdoc/check-redundant-params.js | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/rules/validate-jsdoc/check-param-names.js b/lib/rules/validate-jsdoc/check-param-names.js index 6b742c5..8eb51e7 100644 --- a/lib/rules/validate-jsdoc/check-param-names.js +++ b/lib/rules/validate-jsdoc/check-param-names.js @@ -10,6 +10,10 @@ module.exports.options = { * @param {Function} err */ function validateCheckParamNames(node, err) { + if (!node.jsdoc) { + return; + } + node.jsdoc.iterateByType(['param', 'arg', 'argument'], /** * tag checker diff --git a/lib/rules/validate-jsdoc/check-redundant-params.js b/lib/rules/validate-jsdoc/check-redundant-params.js index df1fb98..076f01b 100644 --- a/lib/rules/validate-jsdoc/check-redundant-params.js +++ b/lib/rules/validate-jsdoc/check-redundant-params.js @@ -10,6 +10,10 @@ module.exports.options = { * @param {Function} err */ function validateCheckParamNames(node, err) { + if (!node.jsdoc) { + return; + } + node.jsdoc.iterateByType(['param', 'arg', 'argument'], /** * tag checker @@ -18,7 +22,7 @@ function validateCheckParamNames(node, err) { */ function(tag, i) { // skip if there is dot in param name (object's inner param) - if (tag.name.value.indexOf('.') !== -1) { + if (tag.name && tag.name.value.indexOf('.') !== -1) { return; }