Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Edit on Github' Button in Documentation not working #1039

Closed
md42 opened this issue Aug 31, 2020 · 0 comments · Fixed by #1043
Closed

'Edit on Github' Button in Documentation not working #1039

md42 opened this issue Aug 31, 2020 · 0 comments · Fixed by #1043
Labels
bug Something isn't working

Comments

@md42
Copy link

md42 commented Aug 31, 2020

Bug Report

e.g. page https://jrnl.sh/usage/ has the Button in upper right with a link to
https://github.com/jrnl-org/jrnl/edit/master/docs/usage.md but because the default branch has been renamed into develop the link does not work

Current Behavior

mentioned link is not working

Expected Behavior

link should work that means pointing to https://github.com/jrnl-org/jrnl/edit/develop/docs/usage.md
@md42 md42 added 🆕 New! bug Something isn't working labels Aug 31, 2020
@wren wren removed the 🆕 New! label Sep 5, 2020
@matildepark matildepark mentioned this issue Sep 8, 2020
Merged
@wren wren closed this as completed in #1043 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Edit on GitHub" button on docs site
2 participants
@md42 @wren