You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, #1011 happened recently. That patches the fact that we shipped v2.4.4 with a missing dependency (packaging). The reason our tests didn't catch it is because that same dependency is required by one of our dev dependencies. And since our tests have the test environment loaded, the dependency was present. This is a problem because we're not testing the actual build.
Environment
Testing environment (travis, local dev, etc)
Current Behavior
Runs tests on a dev build
Expected Behavior
At some point, the tests should be run against an actual packaged build.
Repro Steps
See jrnl v2.4.4
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
stalebot
added
the
stale
Inactive issue: will be closed soon if no activity
label
Oct 7, 2020
@wren and I talked a little about how to implement this today. It doesn't seem like there's a straightforward way to run the behave tests without dev dependencies, but it might make sense to whip up a few basic tests to be runnable from the command line itself. This would have the added benefit of allowing package managers to run automated tests when installing jrnl.
In our CI, we could use a tool like tox to execute those tests.
Bug Report
So, #1011 happened recently. That patches the fact that we shipped v2.4.4 with a missing dependency (
packaging
). The reason our tests didn't catch it is because that same dependency is required by one of our dev dependencies. And since our tests have the test environment loaded, the dependency was present. This is a problem because we're not testing the actual build.Environment
Current Behavior
Runs tests on a dev build
Expected Behavior
At some point, the tests should be run against an actual packaged build.
Repro Steps
See jrnl v2.4.4
The text was updated successfully, but these errors were encountered: