Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't catch missing dependencies that are included in dev #1013

Closed
wren opened this issue Jul 29, 2020 · 2 comments · Fixed by #1504
Closed

Tests don't catch missing dependencies that are included in dev #1013

wren opened this issue Jul 29, 2020 · 2 comments · Fixed by #1504
Labels
build Issues related to the build pipeline 📌 This can't go stale
Milestone

Comments

@wren
Copy link
Member

wren commented Jul 29, 2020

Bug Report

So, #1011 happened recently. That patches the fact that we shipped v2.4.4 with a missing dependency (packaging). The reason our tests didn't catch it is because that same dependency is required by one of our dev dependencies. And since our tests have the test environment loaded, the dependency was present. This is a problem because we're not testing the actual build.

Environment

  • Testing environment (travis, local dev, etc)

Current Behavior

Runs tests on a dev build

Expected Behavior

At some point, the tests should be run against an actual packaged build.

Repro Steps

See jrnl v2.4.4

@wren wren added 🆕 New! build Issues related to the build pipeline labels Jul 29, 2020
@wren wren removed the 🆕 New! label Aug 8, 2020
@stale
Copy link

stale bot commented Oct 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive issue: will be closed soon if no activity label Oct 7, 2020
@micahellison micahellison added the 📌 This can't go stale label Oct 10, 2020
@stale stale bot removed the stale Inactive issue: will be closed soon if no activity label Oct 10, 2020
@micahellison
Copy link
Member

@wren and I talked a little about how to implement this today. It doesn't seem like there's a straightforward way to run the behave tests without dev dependencies, but it might make sense to whip up a few basic tests to be runnable from the command line itself. This would have the added benefit of allowing package managers to run automated tests when installing jrnl.

In our CI, we could use a tool like tox to execute those tests.

@wren wren modified the milestones: Backlog, Unplanned Nov 13, 2021
@wren wren mentioned this issue Jun 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline 📌 This can't go stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants