feat(core):handle display oneof

jremy42 · Mar 28, 2024 · 47f2278 · 47f2278
1 parent 127f1ab
commit 47f2278
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/internal/core/cobra_builder.go b/internal/core/cobra_builder.go
@@ -120,7 +120,7 @@ func (b *cobraBuilder) hydrateCobra(cobraCmd *cobra.Command, cmd *Command, group
 		if len(cmd.Aliases) > 0 {
 			cobraCmd.Annotations["Aliases"] = buildUsageAliases(b.ctx, cmd)
 		}
-
+		
 		if cmd.ArgsType != nil {
 			cobraCmd.Annotations["UsageArgs"] = BuildUsageArgs(b.ctx, cmd, false)
 		}

diff --git a/internal/core/cobra_usage_builder.go b/internal/core/cobra_usage_builder.go
@@ -65,9 +65,28 @@ func BuildUsageArgs(ctx context.Context, cmd *Command, deprecated bool) string {
 // _buildUsageArgs builds the arg usage list.
 // This should not be called directly.
 func _buildUsageArgs(ctx context.Context, w io.Writer, argSpecs ArgSpecs) error {
+	inOneOfGroup := false
+	lastOneOfGroup := ""
+
 	for _, argSpec := range argSpecs {
+
 		argSpecUsageLeftPart := argSpec.Name
 		argSpecUsageRightPart := _buildArgShort(argSpec)
+
+		if argSpec.OneOfGroup != "" {
+			if argSpec.OneOfGroup != lastOneOfGroup {
+				inOneOfGroup = true
+				lastOneOfGroup = argSpec.OneOfGroup
+				_, err := fmt.Fprintf(w, "  %s (one of):\n", argSpec.OneOfGroup)
+				if err != nil {
+					return err
+				}
+			}
+		} else {
+			inOneOfGroup = false
+			lastOneOfGroup = ""
+		}
+
 		if argSpec.Default != nil {
 			_, doc := argSpec.Default(ctx)
 			argSpecUsageLeftPart = fmt.Sprintf("%s=%s", argSpecUsageLeftPart, doc)
@@ -78,6 +97,9 @@ func _buildUsageArgs(ctx context.Context, w io.Writer, argSpecs ArgSpecs) error
 		if argSpec.CanLoadFile {
 			argSpecUsageRightPart += " (Support file loading with @/path/to/file)"
 		}
+		if inOneOfGroup {
+			argSpecUsageLeftPart = "  " + argSpecUsageLeftPart
+		}
 
 		_, err := fmt.Fprintf(w, "  %s\t%s\n", argSpecUsageLeftPart, argSpecUsageRightPart)
 		if err != nil {