Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to add space after gfm codeblocks #22

Closed
blaenk opened this issue Sep 10, 2015 · 5 comments
Closed

option to add space after gfm codeblocks #22

blaenk opened this issue Sep 10, 2015 · 5 comments

Comments

@blaenk
Copy link

blaenk commented Sep 10, 2015

Similar to #18, I would really really really appreciate it if we could set an option to add a space between the codeblock delimiter and the language, like this:

``` language

instead of:

```language

I know it's such a minor thing but this and #18 are the only things that really throw me off from this otherwise amazing markdown package (coming from vim, it's lightyears ahead). I love that I can type the three backticks and then it prompts me for the language automatically, as well as there being the other bind, but I always have to go and add the space manually to remain consistent with the rest of my documents, which breaks my rhythm.

I hope it's not that big of a deal to implement that you wouldn't mind to. I would reaaally appreciate it!

@vyp
Copy link

vyp commented Sep 10, 2015

Big +1, I know it's minor, but I much prefer the space as well.

@jrblevin
Copy link
Owner

This is fine by me. I wrote the code based on the GFM guide but the examples there don't use spaces. However, I verified that it does in fact allow spaces and so do other major processors like PHP Markdown Extra.

@jrblevin
Copy link
Owner

jrblevin commented Nov 2, 2015

I changed things so that 1) a space is allowed for syntax highlighting and 2) a space is added for newly created gfm code blocks. See 59a4986.

@jrblevin jrblevin closed this as completed Nov 2, 2015
@vyp
Copy link

vyp commented Nov 2, 2015

Thanks!

@blaenk
Copy link
Author

blaenk commented Nov 2, 2015

Amazing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants