Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Second Setext Heading and List Formatting Glitch #143

Closed
hmelman opened this issue Jun 10, 2016 · 4 comments
Closed

A Second Setext Heading and List Formatting Glitch #143

hmelman opened this issue Jun 10, 2016 · 4 comments
Labels

Comments

@hmelman
Copy link
Contributor

hmelman commented Jun 10, 2016

Related to #139, there's still a formatting issue with lists if the previous item is indented. Create a list:

  • foo
    • bar

If you begin a new item on the next line at the top level (a - in the first column) , then the bar item will be temporarily formatted as a setext heading (until you add a space after it). It seems setext headings should be prohibited from beginning with a hyphen or whitespace and a hyphen.

@jrblevin
Copy link
Owner

Easy enough. I think that should do the trick, but let me know if not.

@hmelman
Copy link
Contributor Author

hmelman commented Jun 15, 2016

  1. this does fix this case, but it breaks the case in Setext Heading and List Formatting Glitch #139, just top level lists. Seems it only "works" if there's whitespace before the -.
  2. should you also be checking for tabs and not just spaces?

@jrblevin jrblevin reopened this Jun 15, 2016
@jrblevin
Copy link
Owner

I think the above patch should fix this, but let me know if not. I also added tab as a prohibited character as you suggested. Thanks for reporting these issues.

@jrblevin jrblevin added the bug label Dec 22, 2016
@hmelman
Copy link
Contributor Author

hmelman commented Jan 16, 2017

All seems to be working fine for me (sorry for the delay). Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants