Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular lacks some nice to haves for library publishers #2160

Closed
2 tasks done
joshwooding opened this issue Sep 21, 2022 · 1 comment
Closed
2 tasks done

Modular lacks some nice to haves for library publishers #2160

joshwooding opened this issue Sep 21, 2022 · 1 comment
Assignees

Comments

@joshwooding
Copy link
Contributor

joshwooding commented Sep 21, 2022

Building

I discovered this when checking out socket https://socket.dev/npm/package/modular-scripts

You can see that modular is flagged because;

  • No matching license files were found
  • No linked source code repositories were found

Shipping the License sounds ideal since that is what contains the copyright notice.
Attaching source code repositories allows features like npm's linking to work e.g.

image

Which is missing for modular:

image

All these problems could be solved manually but it would be nice if the solutions were built directly into modular so it is automatically handled and improves best practices.

@cristiano-belloni
Copy link
Contributor

The two PRs have been merged, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants