Skip to content

OpenFlights Cookie SameSite attribute not always set

Moderate
jpatokal published GHSA-jc52-8p3x-9p7x Aug 22, 2024

Package

composer jpatokal/openflights (Composer)

Affected versions

<20240822

Patched versions

20240822

Description

Summary

The SameSite attribute of the PHPSESSID cookie is not always set.

Details

The SameSite attribute is set in php/locale.php:

openflights/php/locale.php

Lines 3 to 4 in f53e452

session_set_cookie_params(['samesite' => 'Strict']);
session_start();

It is included on most pages, but not all pages. And sessions are started without session_set_cookie_params(['samesite' => 'Strict']) in multiple places:

openflights/php/countries.php

Lines 1 to 3 in f53e452

<?php
session_start();

openflights/php/flights.php

Lines 1 to 3 in f53e452

<?php
session_start();

openflights/php/kml.php

Lines 1 to 5 in f53e452

<?php
// https://developers.google.com/kml/documentation/kmlreference
session_start();

openflights/php/logout.php

Lines 1 to 3 in f53e452

<?php
session_start();

If one of these pages is the first page visited by a user in a session, the user will receive a cookie without the SameSite attribute.

PoC

Visit https://openflights.org/php/logout.php without cookies to get a cookie with no SameSite attribute.

Impact

Normally users won't visit these unsafe pages before visiting other pages in a session, but an attacker may fool the victim into visiting one of these pages as the first page and then CSRF attacks may follow.

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
Required
Scope
Unchanged
Confidentiality
None
Integrity
Low
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:L/A:N

CVE ID

No known CVE

Weaknesses

Credits