-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcloud import to library itself #16
Comments
Hello @Niccolum, |
So what @Niccolum proposes is this right? - from libcloud.storage.drivers.local import LocalStorageDriver
+ from sqlalchemy_file.drivers import LocalStorageDriver or... - from libcloud.storage.drivers.local import LocalStorageDriver
+ from sqlalchemy_file import LocalStorageDriver If that's the case, I highly recommend using this pattern... - from libcloud.storage.drivers.local import LocalStorageDriver
+ from sqlalchemy_file.storage.drivers.local import LocalStorageDriver In case, if the user decides to import providers from the |
@hasansezertasan as for me, first or latest example are cool. But first is better, because we don't need to repeat the structure of another package, which can change in future |
It's not just "another package", So I vote for the latest example... It's the author's choice after all 🙏. |
As for me, it will be nice, if I import only sqlalchemy_file library to import providers.
Of course, it's only my wish :)
For example, fastapi do it with starlette
https://github.com/tiangolo/fastapi/blob/master/fastapi/requests.py
The text was updated successfully, but these errors were encountered: